-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(type): rspack
function type in cjs require
#8169
Merged
Merged
+76
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team
The issue/pr is created by the member of Rspack.
release: bug fix
release: bug related release(mr only)
labels
Oct 18, 2024
✅ Deploy Preview for rspack canceled.
|
SoonIter
force-pushed
the
type-fix
branch
3 times, most recently
from
October 22, 2024 09:31
2d6638b
to
5a77ecd
Compare
SoonIter
changed the title
fix: the cjs require type and default type
fix(type): function type in cjs require
Oct 23, 2024
This is a solution with a little hack. |
chenjiahan
reviewed
Oct 23, 2024
Agreed, |
chenjiahan
approved these changes
Oct 24, 2024
chenjiahan
changed the title
fix(type): function type in cjs require
fix(type): Oct 24, 2024
rspack
function type in cjs require
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: bug fix
release: bug related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix the function type in cjs require
close #8095
Checklist